SNOW-990111: Modify check to allow permissions without user write

snowflakedb · Jan 26, 2024 · 16335ab · 16335ab
1 parent 9f2c874
commit 16335ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Snowflake.Data.Tests/UnitTests/Session/EasyLoggingStarterTest.cs b/Snowflake.Data.Tests/UnitTests/Session/EasyLoggingStarterTest.cs
@@ -125,7 +125,7 @@ public void TestThatThrowsErrorWhenLogPathIsNotSetAndHomeDirectoryThrowsAnExcept
         }
 
         [Test]
-        public void TestThatDoesNotFailWhenDirectoryPermissionIsNot700()
+        public void TestThatDoesNotFailWhenDirectoryPermissionIsNot600Or700()
         {
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {

diff --git a/Snowflake.Data/Core/Session/EasyLoggingStarter.cs b/Snowflake.Data/Core/Session/EasyLoggingStarter.cs
@@ -154,7 +154,8 @@ private void CheckDirPermissionsOnlyAllowUser(string dirPath)
 
             _unixOperations.SetDirInfo(dirPath);
             var dirPermissions = _unixOperations.GetDirPermissions();
-            if (dirPermissions != FileAccessPermissions.UserReadWriteExecute)
+            if (dirPermissions != FileAccessPermissions.UserReadWriteExecute &&
+                dirPermissions != (FileAccessPermissions.UserRead | FileAccessPermissions.UserExecute))
             {
                 s_logger.Warn($"Access permission for the logs directory is currently " +
                     $"{UnixFilePermissionsConverter.ConvertFileAccessPermissionsToInt(dirPermissions)}");
-Original file line number
+Diff line change
@@ Expand Up @@
             }
             [Test]
-            public void TestThatDoesNotFailWhenDirectoryPermissionIsNot700()
+            public void TestThatDoesNotFailWhenDirectoryPermissionIsNot600Or700()
             {
                 if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
                 {
@@ Expand Down @@