Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove limitation on nested phases/steps #1843

Merged
merged 12 commits into from
Nov 14, 2024
Merged

remove limitation on nested phases/steps #1843

merged 12 commits into from
Nov 14, 2024

Conversation

sfc-gh-mchok
Copy link
Collaborator

@sfc-gh-mchok sfc-gh-mchok commented Nov 8, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Allow nesting phases/steps and also their usages in indents, since we found that we've had bugs multiple times from this and we don't want the console message mechanism to be breaking commands in prod

@sfc-gh-mchok sfc-gh-mchok self-assigned this Nov 8, 2024
@sfc-gh-mchok sfc-gh-mchok requested a review from a team as a code owner November 8, 2024 16:30
@sfc-gh-mchok sfc-gh-mchok requested a review from a team as a code owner November 8, 2024 16:57
@sfc-gh-fcampbell
Copy link
Contributor

I'm OK with this, might wanna run it y @sfc-gh-bdufour since he added the limitation initially

@sfc-gh-mchok sfc-gh-mchok merged commit 86359a5 into main Nov 14, 2024
21 checks passed
@sfc-gh-mchok sfc-gh-mchok deleted the mchok-cli-nested-phases-in-validate-and-processors branch November 14, 2024 16:09
sfc-gh-ashen pushed a commit that referenced this pull request Nov 14, 2024
@sfc-gh-mchok @sfc-gh-ashen
remove limitation on nested phases/steps (#1843)
6399845 
* remove limitation on nested phases/steps

* remove unused error

* add integ test for validate with artifacts processor

* rename tests for clarity and add one more nested phase for deep nesting

* make phase in indent test more robust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-fcampbell sfc-gh-fcampbell sfc-gh-fcampbell left review comments

Assignees

@sfc-gh-mchok sfc-gh-mchok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-mchok @sfc-gh-fcampbell @sfc-gh-astus @sfc-gh-bdufour