Update example apps #13
Conversation
sfc-gh-pjafari
commented
Aug 29, 2024
•
sfc-gh-pjafari
commented
- add missing readme files
- remove "create security integration" step from spcs example as it's no longer needed. See jira ticker
| @@ -1,5 +1,4 @@ | |||
| set -e | |||
| snow sql -f "prepare/spcs_setup.sql" | |||
There was a problem hiding this comment.
why are we removing this? Maybe some context would help.
There was a problem hiding this comment.
It's no longer needed. updated PR description with Jira ticket :)
https://snowflakecomputing.atlassian.net/browse/SNOW-1527720
| if [ "$ret" = 5 ]; then | ||
| echo "No tests collected." | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
curious: how did you run into this?
There was a problem hiding this comment.
good question :D not all sample projects have python code/python tests. by default, pytest exits with error code 5 if that's the case.
The action is still not passing though so I gotta look into it more (it worked when I tested locally).
There was a problem hiding this comment.
I see, the workflow is failing. I'm a bit rusty, does GH pick up the new workflow from the PR, or would you have to merge this first? If it's running the version from main, your fix won't take effect yet...
There was a problem hiding this comment.
It's running the ci from this PR, I can see my change in the action logs.
There was a problem hiding this comment.
Also, the CI is known to be broken right now. So no worries about failing runs at the moment, just run the tests locally and confirm they're passing before merge.
