Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1821508: OCSP deprecation plan steps #789

Merged
merged 2 commits into from
Dec 4, 2024
Merged

SNOW-1821508: OCSP deprecation plan steps #789

merged 2 commits into from
Dec 4, 2024

Conversation

sfc-gh-ext-simba-hx
Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx commented Dec 2, 2024 •
edited
Loading

teamwork issue 1179

  • targeting 2.0.0
  • default behavior from FAIL_CLOSE to FAIL_OPEN
  • FAIL_OPEN log changed (log level unchanged since curl only have info and error log, and the log is info level already)
  • log error for responder URL missing only when it's FAIL_CLOSE
  • FAIL_CLOSE retry from 3 to 2. FAIL_OPEN retry and cache server retry are 1 already unchanged.
  • Confirmed timeout is correct already.
  • No change for insecureMode since libsfclient doesn't have such attribute and is using SF_GLOBAL_OCSP_CHECK to enable/disable OCSP check.

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx requested a review from a team as a code owner December 2, 2024 23:46
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-1821508-OCSP-deprecation-initial branch from f4ac980 to c9e3863 Compare December 4, 2024 00:01
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx changed the base branch from master to master-2.0.0 December 4, 2024 00:02
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx merged commit 0f9f288 into master-2.0.0 Dec 4, 2024
42 checks passed
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx deleted the SNOW-1821508-OCSP-deprecation-initial branch December 4, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski sfc-gh-jszczerbinski approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz Awaiting requested review from sfc-gh-dprzybysz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-hx @sfc-gh-pfus @sfc-gh-jszczerbinski