SNOW-1831184 Exclude nghttp2 from curl build on unix #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recent macos image
sfc-gh-dprzybysz
approved these changes
Nov 27, 2024
sfc-gh-mkubik
changed the title
sfc-gh-jszczerbinski
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1831184
The recent macos build failures seem to be caused by problems with linking
nghttp2library. According to the logs, build was ignoring this dependency on older versions of macos image since the library wasn't available at all but it's no longer the case.This PR attempts to solve the MacOS build issue by explicitly excluding the
nghttp2dependency from curl build.