SNOW-1524269: support put/get for GCP #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-hx
requested review from
sfc-gh-pkochmanski,
sfc-gh-dprzybysz,
sfc-gh-dstempniak and
sfc-gh-jszczerbinski
sfc-gh-ext-simba-hx
force-pushed
the
SNOW-1524269-put-get-with-gcp
branch
from
a45b4df to
accc73b
Compare
sfc-gh-ext-simba-hx
force-pushed
the
SNOW-1524269-put-get-with-gcp
branch
from
5f1348c to
4ace536
Compare
Noted down in the ticket discussed about that with @sfc-gh-dstempniak before. |
sfc-gh-dprzybysz
approved these changes
Oct 11, 2024
sfc-gh-dprzybysz
requested changes
Oct 21, 2024
sfc-gh-dprzybysz
approved these changes
Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teamwork issue 1035
part 1 for GCP support, will have separated PR to support PUT/GET natively.
Draft for now as temporary changes included to fake the client to be ODBC to pass test. Without that we would get error of "gcs downscoped token not supported" from server.
We would need server change to enable PUT/GET on GCS for libsnowflakeclient (maybe for PHP as well).