Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-983106: libsnowflakeclient - possible resource leak due to exit call #655

Merged
5 commits merged into from
Feb 7, 2024

Conversation

sfc-gh-ext-simba-jz
Copy link
Collaborator

When errors occur in allocation memory, instead of calling exit() to abort the process,

it is more elegant as a library to throw an exception and let the application/caller make decision.

@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz requested review from sfc-gh-igarish and a user January 11, 2024 18:08
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz marked this pull request as ready for review January 11, 2024 18:09
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz requested a review from a team as a code owner January 11, 2024 18:09
CMakeLists.txt Outdated Show resolved Hide resolved
cpp/util/SnowflakeCommon.cpp Outdated Show resolved Hide resolved
cpp/util/SnowflakeCommon.cpp Outdated Show resolved Hide resolved
include/snowflake/platform.h Outdated Show resolved Hide resolved
…abort the process,

it is more elegent as a library to throw an exception and let the application/caller make decision.
throw proper exception
@ghost ghost force-pushed the b784-bad-exit-call branch from d467b66 to 193e90a Compare February 6, 2024 23:53
@ghost ghost requested a review from sfc-gh-dprzybysz February 7, 2024 01:08
@ghost ghost merged commit 773e6a1 into master Feb 7, 2024
24 checks passed
@ghost ghost deleted the b784-bad-exit-call branch February 7, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants