Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-968730: Increased max LOB size complete testing #652

Merged
4 commits merged into from
Jan 26, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2024

sdk issue 751

This PR is for testing only. make it draft and won't merge for now.
Need to increase MAX_LOB_SIZE definition to test on Snowflake side.
The test case could be merged when the feature is stable and can be released, but at that time we might need to reduce the test cases (especially the number of sizes being tested) as currently it might take too much time to run due to the large data size.

@ghost ghost marked this pull request as draft January 8, 2024 23:56
@ghost ghost self-requested a review as a code owner January 8, 2024 23:57
@ghost ghost force-pushed the SNOW-968730-test-increased-lob-size branch from d785b2d to 8e1abf0 Compare January 25, 2024 00:41
@ghost ghost marked this pull request as ready for review January 25, 2024 18:08
@ghost
Copy link
Author

ghost commented Jan 25, 2024

@sfc-gh-dprzybysz
Just to confirm we can merge this PR, right? The test result looks good and the new test case is commented out so it won't break anything.

@sfc-gh-dprzybysz
Copy link
Collaborator

@sfc-gh-dprzybysz Just to confirm we can merge this PR, right? The test result looks good and the new test case is commented out so it won't break anything.

@sfc-gh-ext-simba-hx yes, you can merge it

@ghost ghost merged commit 3e3ec4e into master Jan 26, 2024
24 checks passed
@ghost ghost deleted the SNOW-968730-test-increased-lob-size branch January 26, 2024 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants