Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-950725: remove unused arrow code causing snyk issue #594

Merged
1 commit merged into from
Oct 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2023

We actually only use the code under cpp folder. Remove the code with all other languages.
Deleted following language specific folders:

  • c_glib
  • csharp
  • go
  • java
  • js
  • matlab
  • python
  • r
  • ruby
  • rust

@ghost ghost self-requested a review as a code owner October 25, 2023 18:13
@ghost ghost requested a review from sfc-gh-igarish October 25, 2023 19:33
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than 2K files. All related ARROW third party source code. So not reviewing it. But suggest to create a doc when we upgrade ARROW libs, how to strip it again. Merge it once all gates pass.

@ghost ghost force-pushed the SNOW-950725-sync-report-remove-arrow-code branch from 35828da to 2ada4bc Compare October 26, 2023 12:22
@ghost ghost merged commit 4097f15 into master Oct 26, 2023
22 of 23 checks passed
@ghost ghost deleted the SNOW-950725-sync-report-remove-arrow-code branch October 26, 2023 17:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants