Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-932679: reduce delay on ocsp timeout #572

Merged
3 commits merged into from
Oct 25, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2023

Fix for both sdk issue 692 and 706
Before the fix if the OCSP validate requests failed with timeout it could cause 15 (5 seconds timeout on cache downloading and 5 seconds timeout * 2 retries on fetch request) seconds delay per entry in the certificate chain, with typically 4 entries in the chain the total delay could be up to 60 seconds and could fail the SSL connection even the driver try to establish the connection with FAIL_OPEN mode.
The fix is to remember the host name reached timeout in previous entry and skip further attempt on the same host in following entries to reduce the delay.

@ghost ghost self-requested a review as a code owner October 23, 2023 17:47
@ghost ghost requested a review from sfc-gh-igarish October 23, 2023 17:50
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost force-pushed the SNOW-932679-reduce-delay-on-ocsp-timeout branch from 6d3ec20 to fed93f6 Compare October 25, 2023 14:05
@ghost ghost merged commit d6e0609 into master Oct 25, 2023
22 checks passed
@ghost ghost deleted the SNOW-932679-reduce-delay-on-ocsp-timeout branch October 25, 2023 16:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants