gptjudge empty response handling #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -405,7 +405,10 @@ def gpt4judge(references, predictions, query): # This is a passthrough function | |||
| eval_logger.error(f"All 5 attempts failed. Last error message: {str(e)}.\nResponse: {str(error_msg)}") | |||
| response = "" | |||
|
|
|||
| score = int(extract_number_from_brackets(response)) | |||
| if response is None: # Rare case of gpt returning empty response | |||
| score = 0 | |||
There was a problem hiding this comment.
Can we do a try+except wrapping extract_number_from_brackets, and also add logging whenever this is caught?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally when using gpt as a judge, the response is empty. From our test set, this occurred only once and is considered incorrect by default.
Test command:
python3 -m accelerate.commands.launch \ --num_processes=1 \ -m lmms_eval \ --model internvl2 \ --model_args pretrained="/import/ml-sc-scratch3/nidhih/mm_hungarian/finetune_outputs/pretrain_hupdf2_synthdog_hu_all_unfrozen" \ --tasks docvqa_hu_syn \ --batch_size 1 \ --log_samples \ --log_samples_suffix intervl2_8b \ --output_path /import/ml-sc-scratch3/nidhih/mm_hungarian/lmms_eval_op/internvl2_8b_docvqasyn_pt_test \ --limit 200