Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for post_authenticate signal #351

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ajw725
Copy link
Contributor

@ajw725 ajw725 commented Oct 17, 2024

I fumbled around for a while trying to figure out how to execute some custom code after a user is created/authenticated via SSO before I found the post_authenticate signal in the source code. I didn't see it in the docs, and having it in there would have saved me some time.

I didn't really think it fit into any of the existing sections, but if you'd prefer it to be in there (maybe under installation, I guess?), let me know and I can move it.

@JonasKs
Copy link
Member

JonasKs commented Oct 17, 2024

Thanks! This looks good to me☺️

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to have, thank you! Let me know what you think of my suggestions. If you don't have time to implement them, I can help.

docs/signals.rst Outdated Show resolved Hide resolved
docs/signals.rst Outdated Show resolved Hide resolved
docs/signals.rst Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ajw725 ajw725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can implement those, no problem. should be able to get to it this weekend if not before. thanks for the suggestions!

docs/signals.rst Outdated Show resolved Hide resolved
docs/signals.rst Outdated Show resolved Hide resolved
@ajw725
Copy link
Contributor Author

ajw725 commented Oct 21, 2024

@tim-schilling i think i got all those - let me know if that looks ok!

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you a ton!

@tim-schilling tim-schilling merged commit 9f3c6f3 into snok:main Oct 21, 2024
25 of 26 checks passed
@ajw725 ajw725 deleted the signals-docs branch October 22, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants