Rcorr fix #30
Open
Rcorr fix #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to carefully adapt the currently failing unit tests. The tests simply check for a given result, |
|
Hi, the changes look good to me, but any idea why we have |
|
sorry, no
…On Sat, 21 Mar 2020 at 21:25, Steffen Neumann ***@***.***> wrote:
Hi, the changes look good to me, but any idea why we have
the failures in e.g.
https://travis-ci.org/github/sneumann/CAMERA/builds/381696732#L6329 ?
Yours, Steffen
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA32RUTJMCT73FQDHMTY4HDRIUWDTANCNFSM4FA4IMWA>
.
--
Dr. Tony R. Larson
Head of Metabolomics & Proteomics, Department of Biology, Area 15
University of York
Wentworth Way
Heslington
York YO10 5DD
UK
Tel: +44(0)1904 328 733 (office)
Tel: +44(0)7833 471 685 (mobile)
[email protected]
http://scholar.google.com/citations?user=9hLFka4AAAAJ
www.york.ac.uk/biology/technology-facility/proteomics/
www.york.ac.uk/mass-spectrometry
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcorr() returns r values of 1 and p values of 0 for n = 2 comparisons. This leads to many false-positive groupings of pseudospectra represented by sparse EICs. The default should be only to correlate when n = 4 or greater. rcorr() is not catching these because it is counting NA in the EIC matrix in its checks. However, the n values returned by rcorr handily give the number of non-NA comparisons, so code has be updated to filter by a n > 3 threshold, in addition to the the existing r and p thresholds.