-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hierarchical depth culling for meshlets #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndels
force-pushed
the
cluster-depth-culling
branch
2 times, most recently
from
August 3, 2024 07:56
b882fd1
to
bb9b176
Compare
Makes it easier to grep where it's being used and cleans up ctor interfaces to the bare essentials.
sndels
force-pushed
the
cluster-depth-culling
branch
2 times, most recently
from
August 3, 2024 08:54
e3114f6
to
1be8a90
Compare
App was getting hard to look through so let's try having the main draw stuff separately.
… subresourceView()
sndels
force-pushed
the
cluster-depth-culling
branch
from
August 3, 2024 08:56
1be8a90
to
9c635e8
Compare
Isn't conservative for disocclusion yet. That needs the two-pass setup from Aaltonen.
sndels
force-pushed
the
cluster-depth-culling
branch
from
August 3, 2024 10:48
9c635e8
to
fe956d6
Compare
Also move meshlet culler as a init input to the geometry renderers because the same instance is always passed in. Similarly, have the geometry renderers own hierarchical depth history to keep it contained where it is needed.
Can't modify a value twice between sequence points.
Link times go from almost 10s down to 1.5s
sndels
force-pushed
the
cluster-depth-culling
branch
from
August 3, 2024 10:51
fe956d6
to
608b198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.