Fix increment UB

Can't modify a value twice between sequence points.
sndels · Aug 3, 2024 · 2b2e82f · 2b2e82f
1 parent 11d0713
commit 2b2e82f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/render/RtReference.cpp b/src/render/RtReference.cpp
@@ -176,7 +176,7 @@ RtReference::Output RtReference::record(
 
     PROFILER_CPU_SCOPE("RtReference");
 
-    m_frameIndex = ++m_frameIndex % sFramePeriod;
+    m_frameIndex = (m_frameIndex + 1) % sFramePeriod;
 
     Output ret;
     {

diff --git a/src/render/rtdi/RtDiInitialReservoirs.cpp b/src/render/rtdi/RtDiInitialReservoirs.cpp
@@ -104,7 +104,7 @@ RtDiInitialReservoirs::Output RtDiInitialReservoirs::record(
 
     PROFILER_CPU_SCOPE("  InitialReservoirs");
 
-    m_frameIndex = ++m_frameIndex % sFramePeriod;
+    m_frameIndex = (m_frameIndex + 1) % sFramePeriod;
 
     Output ret;
     {

diff --git a/src/render/rtdi/RtDiTrace.cpp b/src/render/rtdi/RtDiTrace.cpp
@@ -149,7 +149,7 @@ RtDiTrace::Output RtDiTrace::record(
 
     PROFILER_CPU_SCOPE("  Trace");
 
-    m_frameIndex = ++m_frameIndex % sFramePeriod;
+    m_frameIndex = (m_frameIndex + 1) % sFramePeriod;
 
     Output ret;
     {