Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update rustls-native-certs to 0.8 #348

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Sep 4, 2024

The load_native_certs() function now returns all errors instead of raising only the first error.

Not finding any native root CA certificates is not fatal if the "rustls-tls-webpki-roots" feature is enabled.

src/tls.rs Outdated

// Not finding any native root CA certificates is not fatal if the
// "rustls-tls-native-roots" feature is enabled.
#[cfg(not(feature = "rustls-tls-native-roots"))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a #[cfg(feature = "rustls-tls-native-roots")] block, so would never be compiled in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it should be "rustls-tls-webpki-roots".

The `load_native_certs()` function now returns all errors instead of
raising only the first error.

Not finding any native root CA certificates is not fatal if the
"rustls-tls-webpki-roots" feature is enabled.
@daniel-abramov daniel-abramov merged commit 0b9d97b into snapview:master Sep 5, 2024
5 checks passed
@nickelc nickelc deleted the deps/rustls-native-certs branch September 5, 2024 18:01
zitsen added a commit to taosdata/tokio-tungstenite that referenced this pull request Sep 9, 2024
* master:
  deps: update `rustls-native-certs` to 0.8 (snapview#348)
  Additional Documentation of `IntoClientRequest` on `connect_async` (snapview#342)
  Prepare 0.23.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants