-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speeding up BigClam implementation #210
Open
liuchbryan
wants to merge
30
commits into
snap-stanford:master
Choose a base branch
from
liuchbryan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r for bin directory
…ADME and makefile accordingly
…ailed comparison function
…ning on apple defailt clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change speeds up the C++ implementation for BigClam (Yang & Leskovec, 2013). It parallelises the computation in the stage where one reads off the community affiliation from the factorised affiliation weights matrix, which currently dominates the runtime and was yet unparallelised.
Detailed context and running instructions are available on
contrib/ICL-bigclam_speedup/README.md
The actual changes to the main SNAP library is only a few lines - in
snap-adv/agmfast.cpp
. The bulk of the work is toThe latter requires a custom utility
contrib/ICL-bigclam_speedup/src/cmtycompare.cpp
as the community affiliations are stored in SNAP (C++) as vectors of vectors instead of sets of sets.To prevent interference with the main SNAP library, we have copied out the header and cpp files in
examples/bigclam
and the originalsnap-adv/agmfast.cpp
. These files can be found incontrib/ICL-bigclam_speedup/src/
. We also use a separateMakefile
largely similar to that in the main project when we build our executables.Please let me know if you have any questions!
Bryan
P.S.: Apologies for sending in the pull request late - I know Node2Vec or GNNs are now the dominating tools, though given BigClam's accumulated significance I will be doing it a disservice for not reducing the runtime when I can!