Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: bump datavzrd wrapper to 2.6.0 and general bug fixes #80

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

manuelphilip
Copy link
Collaborator

Created a new and separate pull request previously was merged with 3-prime-rna branch

@manuelphilip manuelphilip changed the title perf bump datavzrd wrapper to 2.6.0 and general bug fixes perf: bump datavzrd wrapper to 2.6.0 and general bug fixes Sep 1, 2023
Copy link
Collaborator

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightforward to me. Thanks for creating the cleaner pull request, to replace #79 with lots of unrelated commits in it.

@dlaehnemann
Copy link
Collaborator

Also, I added another pull request, namely to:

  1. Make release please happy. It previously gave this error about the commit message of the only commit:
Error: Pull request has only one commit and it's not semantic; this may lead to a non-semantic commit in the base branch (see https://github.community/t/how-to-change-the-default-squash-merge-commit-message/1155). Amend the commit message to match the pull request title, or add another commit.
  1. Also make the formatting step of the CI happy. So generally, running snakefmt workflow/ on a branch when creating a pull request makes sense, as otherwise the formatting step will very often complain.

@manuelphilip
Copy link
Collaborator Author

manuelphilip commented Sep 1, 2023

Yeah, Actually I was searching for this error message that came previously. Can you point me to the change
that you made to resolve this error?

Yea, I have the extension installed in my vscode for snakefmt format. But forgot to run it before pushing :(

@dlaehnemann
Copy link
Collaborator

Just click on the commit snakefmt, which is listed above my last comment. So all I did was run snakefmt workflow/ locally, commit it via git to this branch and push it here.

@dlaehnemann dlaehnemann merged commit 657c465 into main Sep 1, 2023
5 checks passed
@dlaehnemann dlaehnemann deleted the datavzrd-2-6-0-and-plot-dimensions branch September 1, 2023 09:57
johanneskoester pushed a commit that referenced this pull request Jan 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.5.2](v2.5.1...v2.5.2)
(2023-09-14)


### Bug Fixes

* simpler three prime QuantSeq cutadapt setup
([#78](#78))
([ecc9ab7](ecc9ab7))
* update samtools.yaml to latest `1.17` and update github actions
([#75](#75))
([0fe7948](0fe7948))


### Performance Improvements

* bump datavzrd wrapper to 2.6.0 and general bug fixes
([#80](#80))
([657c465](657c465))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants