fix: update samtools.yaml to latest 1.17 and update github actions
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaehnemann
changed the title
1.171.17
dlaehnemann
changed the title
1.171.17
dlaehnemann
changed the title
1.171.17 and update github actions
|
Hi @dlaehnemann , sure you can update it to latest version and it should run |
johanneskoester
approved these changes
Aug 16, 2023
johanneskoester
pushed a commit
that referenced
this pull request
Jan 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.5.2](v2.5.1...v2.5.2) (2023-09-14) ### Bug Fixes * simpler three prime QuantSeq cutadapt setup ([#78](#78)) ([ecc9ab7](ecc9ab7)) * update samtools.yaml to latest `1.17` and update github actions ([#75](#75)) ([0fe7948](0fe7948)) ### Performance Improvements * bump datavzrd wrapper to 2.6.0 and general bug fixes ([#80](#80)) ([657c465](657c465)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@manuelphilip Was there a reason for the old version of
samtools =1.9? Otherwise I would update this to the latest version.I found this, because we were seeing very large memory usage (
> 20GB) for therule get_mapped_canonical_transcripts, which should stream through the BAM (and the BAMs we had were below1GB), so I wouldn't expect any large memory usage. The only explanation I have so far, is that maybe this very old version of samtools somehow had a bug or very suboptimal handling of BAM files.