Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert pval and qval to heatmap #123

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: Convert pval and qval to heatmap #123

merged 1 commit into from
Oct 17, 2024

Conversation

fxwiegand
Copy link
Contributor

@fxwiegand fxwiegand commented Oct 16, 2024

This PR converts pval and qval in the transcripts view of the diffexp report from bar plots to heatmaps.

Summary by CodeRabbit

  • New Features
    • Enhanced visualization of statistical values with heatmap representations for pval and qval in both transcripts and genes_aggregated datasets.
    • Updated domain values for improved clarity in significance levels.

These changes provide a more detailed and visually informative way to interpret data significance.

Copy link

coderabbitai bot commented Oct 16, 2024

Walkthrough

The changes in the diffexp-template.yaml file involve a transition from bar plots to heatmap visualizations for the pval and qval columns in both the transcripts and genes_aggregated datasets. The domain ranges for these values have been refined from [0.0, 1.0] to specific points [0, 0.05, 0.25], allowing for a more detailed representation of significance levels. The color scale for the heatmaps has been standardized to ["#a1d99b", "white", "#fdae6b"].

Changes

File Path Change Summary
workflow/resources/datavzrd/diffexp-template.yaml - Updated plot type for pval and qval in transcripts and genes_aggregated from bars to heatmap
- Updated domain for pval and qval in transcripts and genes_aggregated from [0.0, 1.0] to [0, 0.05, 0.25]
- Defined heatmap color scale as ["#a1d99b", "white", "#fdae6b"] for both pval and qval

Poem

In the land of data, where values play,
Heatmaps now dance, in a colorful array.
From bars to warmth, significance glows,
With shades of green and red, the insight flows.
A hop and a skip, let the numbers sing,
For clearer visuals, let the heatmap spring! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
workflow/resources/datavzrd/diffexp-template.yaml (1)

214-235: LGTM! Consider adding a legend for clarity.

The change from bar plots to heatmaps for 'pval' and 'qval' visualization is a good improvement. The new domain [0, 0.05, 0.25] provides better granularity for significant values, and the color range is appropriate for representing significance levels.

Consider adding a legend to explain the color scale, especially since the domain is not evenly distributed (0, 0.05, 0.25). This would help users interpret the heatmap more accurately.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7b2767c and 9c457cc.

📒 Files selected for processing (1)
  • workflow/resources/datavzrd/diffexp-template.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
workflow/resources/datavzrd/diffexp-template.yaml (1)

Line range hint 1-337: Summary of changes and recommendations

  1. The changes for the 'transcripts' dataset successfully implement heatmaps for 'pval' and 'qval' visualization, improving the representation of significance levels.

  2. There's a discrepancy between the AI-generated summary and the visible changes regarding the 'genes_aggregated' dataset. This needs to be verified and addressed if necessary.

  3. Consider adding a legend to the heatmaps to improve interpretability, especially given the non-linear domain distribution.

Overall, the implemented changes align well with the PR objectives of enhancing the visualization of p-values and q-values in the differential expression report.

🧰 Tools
🪛 yamllint

[error] 237-237: trailing spaces

(trailing-spaces)

Copy link
Collaborator

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So if you have tested that this all works, feel free to merge. One thing I would double-check, is that values above 0.25 work with this domain definition. But you're the datavzrd expert, here... ;)

@fxwiegand
Copy link
Contributor Author

LGTM. So if you have tested that this all works, feel free to merge. One thing I would double-check, is that values above 0.25 work with this domain definition. But you're the datavzrd expert, here... ;)

Works for sure. I think the default for clamp is true so color wise this will get clamped but that is ok I guess (if not even intended).

@fxwiegand fxwiegand merged commit 478c759 into main Oct 17, 2024
7 checks passed
@fxwiegand fxwiegand deleted the fxwiegand-patch-2 branch October 17, 2024 13:01
dlaehnemann pushed a commit that referenced this pull request Oct 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.8.2](v2.8.1...v2.8.2)
(2024-10-18)


### Bug Fixes

* Convert pval and qval to heatmap
([#123](#123))
([478c759](478c759))
* Move NA values to end of table
([#124](#124))
([df807a5](df807a5))
* Update max in memory rows for diffexp report
([#122](#122))
([830e678](830e678))


### Performance Improvements

* Update to latest datavzrd wrapper
([#125](#125))
([3a4c020](3a4c020))
* Update to latest datavzrd wrapper version
([#120](#120))
([7b2767c](7b2767c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants