fix: Fix meta comparison and wildcard issue #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Laehnemann <[email protected]>
Co-authored-by: David Laehnemann <[email protected]>
Co-authored-by: David Laehnemann <[email protected]>
Co-authored-by: David Laehnemann <[email protected]>
…a-seq-kallisto-sleuth into fxwiegand-patch-1
fxwiegand
changed the title
dlaehnemann
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Nice cleanup and great to have tests running on this functionality.
Also, I started digging into polars (vs. pandas) functionality a bit, and found some spots where we might be able to clean up the syntax and avoid switching back to pandas. But if the suggestions don't simply work, it might make sense to get back to Adrian (and possibly Johannes), about some of the questions, as there might have been conscious decisions against using a particular polars functionality...
…a-seq-kallisto-sleuth into fxwiegand-patch-1
…a-seq-kallisto-sleuth into fxwiegand-patch-1
|
@dlaehnemann I think we are ready for a final review now 😊 |
dlaehnemann
approved these changes
Sep 11, 2024
|
Ah, didn't see the auto-merge... 🙈 |
dlaehnemann
pushed a commit
that referenced
this pull request
Sep 11, 2024
This PR does some minor refactoring in the meta comparison code as they were still some comments from @dlaehnemann in #113 that havent been addressed.
johanneskoester
pushed a commit
that referenced
this pull request
Sep 12, 2024
🤖 I have created a release *beep* *boop* --- ## [2.7.2](v2.7.1...v2.7.2) (2024-09-11) ### Bug Fixes * Fix meta comparison and wildcard issue ([#113](#113)) ([3f8f126](3f8f126)) * Fix meta comparison model and label path ([#111](#111)) ([27b9cb1](27b9cb1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates meta_comparison for testing and contains some fixes for it by @Addimator. I also altered a path that was causing issues with wildcards in the goatools enrichment rule.