Fixes for next/2016.07 #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eugeneia
commented
Jul 8, 2016
eugeneia
commented
- This should fix the performance regression reported in next: Changes queued for the v2016.07 release #956 (only did a quick comparison, we should wait for hydra to confirm) by removing statistics callbacks from virtio code and reverting an attempted optimization that backfired
- Also includes Fix interface speed #963
The counter value for the interface speed should be in units of bps. The ifSpeed SNMP object must obey RFC3635 sec. 3.2.8.
|
Hydra report here: https://hydra.snabb.co/build/136747/download/2/report.html Great that we are putting our new benchmarking infrastructure into practice! The report clearly shows a subtle performance regression that is very easy to miss in interactive benchmarking due to subtle variation between runs. I am having a read of some JIT dumps to understand why counter bumping is influencing the benchmark scores so much. Seems like it should be a very cheap operation in principle. |
# Conflicts: # src/apps/vhost/vhost_user.lua
lukego
added a commit
that referenced
this pull request
Jul 13, 2016
dpino
added a commit
to dpino/snabb
that referenced
this pull request
Sep 27, 2017
Move alarms subprograms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.