Merge max-next into next for v2019.01 #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ipv6-frag-pmtud
…into ipv6-reass-expire
Frequent trace aborts due to "register coalescing too complex" have been observed within handle_fragment(). This commit attempts to mitigate this by limiting the scope of local variables, either by explicit scoping with do/end or by placing variable declarations after function calls that don't need them.
The main processing loop is split into three separate loops to reduce the effect of unbiased branches due to workloads with either mixed fragmented/unfragmented packets or a shift from mainly fragmented to mainly unfragmented packets on the selection of traces. All packets needing fragmentation are processed in a separate loop. The fragmentation itself contains another loop which might get compiled first. In that case, the pointers passed to fragment_and_transmit() would require dynamic boxing on the Lua stack, which cause GC activity. Explicit boxing is used to avoid this.
The amount of work being done in the main push() loop is reduced by moving fragments to a separate queue. This is beneficial if the workload is unbiased with respect to fragmentation or if the workload shifts from mainly fragmented to mainly unfragmented packets. All packets needing reassembly are processed in a separate loop.
Move the logger out of core.lib into lib.logger and add documentation. Simplify the throttling code by tying it to the logging of discarded messages. Update in-tree references to the logger. Remove the token_bucket:rate() method which was kept for backward compatibility for the old logger code.
Calibration causes long delays in some selftests that instantiate the new logger.
The snippets of code that deal with the remaining bytes should be ifs and not whiles. For instance, if the remaining bytes to sum are 7, this number is decomposed as 4 + 2 + 1. For all other numbers lower to 8 their decomposition is a sum of different values, thus there won't be iterations.
The change required to support third argument 'initial', return value as host-byte order value and adapt some selftests.
Found via GCC 8.2's -Werror=stringop-truncation. NUL termination is required by the AF_UNIX socket API.
Add an optional callback which is invoked on an evicted entry to perform cleanup before the entry is purged from the table.
Make sure that packet.append() is called with a pointer of type uint8_t *. The detection of ICMP packets for PMTUD is simplified by only checking for next_header 58 on the fast path.
Respect the precondition for sort_array(). Use bit.band instead of modulo operator to check for multple of 8 of the fragment size.
The headers of all fragments are derived from the unfragmentable part of the original packet, hence the distinction for fragment #0 is not necessary.
On a call to get_mempolicy, the maxnode argument should match the size of the given nodemask to avoid buffer overruns. This commit ensures the size is ok when ljsyscall generates the nodemask structure. Cherry-picked from: Igalia#1198
The operator specializes to bitops automatically.
|
|
Is the problem with |
Take padding to minimum Ethernet frame size into account.
lukego
added a commit
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: