Add snabb config test functionality #1339
Conversation
benagricola
force-pushed
the
config-test
branch
2 times, most recently
from
3a83c4f to
3b0e5f3
Compare
Reworks `snabb config` command line parsing somewhat to allow `snabb config test` to work. `snabb config test` loads a schema passed with `-s` either by name (if already known by snabb) or by file path, then validates a passed configuration FILE against the schema. Signed-off-by: Ben Agricola <[email protected]>
There was a problem hiding this comment.
Looking good :) Some comments. Also, do you think it ever makes sense to use a compiled file? I have the feeling that we should always be "testing" source. (Should this command be named "snabb config compile" instead, and make it compile a configuration instead?)
| @@ -53,8 +53,10 @@ function load_configuration(filename, opts) | |||
| end | |||
| local function err(msg, ...) error(err_msg(msg, ...)) end | |||
| local function log(msg, ...) | |||
| io.stderr:write(err_msg(msg, ...)..'\n') | |||
| io.stderr:flush() | |||
| if opts.verbose then | |||
There was a problem hiding this comment.
I think we need to change the default above at line 34 to verbose={default=true}, to keep the current behavior for existing callers.
| if opts.require_schema then err("missing --schema arg") end | ||
| ret.schema_name = descr.default_schema | ||
|
|
||
| if opts.command == 'test' then |
There was a problem hiding this comment.
I dunno, I think since there's these two ways to deal with the schema -- either as provided by the user or as received from the remote -- I think it makes sense to move all argument handling to test.lua, to avoid making this common.lua too specific on the commands being used. WDYT?
|
FWIW there is an ad-hoc implementation of this functionality in vita so this will be very useful to me! ❤️ |
|
@wingo re: should we ever config test a compiled file - no, that's a good point 😃- I'll rework this as |
|
(JFYI I didn't merge this on my sweep through open PRs just now because based on the discussion it seems like changes are pending.) |
|
Yep, pending a rewrite I'm hoping to get around to after more |
@wingo as mentioned on Slack earlier 🙂
Reworks
snabb configcommand line parsing slightly to implementsnabb config test.snabb config testloads a schema passed with-seither by name (if already known by snabb) or by file path, then validates a passed configuration FILE against the schema.If no
-sis given butIDis passed, thenconfig testattempts to connect to the instance and grab the current schema.Also modifies the
log()function so that informational log messages like the ones below are only printed when verbose is passed toyang.load_configuration:NOTE: WIP as I haven't tested this against running snabb instances yet, will complete this next week.