Fix: relative references starting with ./ were not replaced on Windows
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example reference to `./subdir/otherfile.html` from `c:\somedir\somefile.html` having windows directories with back-slahses (\) confused the logic in get_reference_representations_relative to determine relative paths between two files
due to usage of nodejs Paths.dirname I could not get the windows tests to work on Linux/Mac as the \ character is not used as path separator by Paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having a reference such as
./subdir/otherfile.txtwas not replaced with the hashed filename on Windows.This issue was caused by determining the relative paths between
c:\somedir\somefile.txtandc:\somedir\subdir\otherfile.txt. In the implementation this caused directoriesc:\somedir/to be compared toc:\somedir\subdir/to determine if the second one is a subdir of the first one, which fails because of the usage of both / andThis issues only reproduces on windows because of the \ usage. Relative references like
subdir/otherfile.txtwere replaced correctly, it's just with the./prefix that things went wrong.