Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: manifestfile only contains/outputs js and css changes? (edit: misread documentation) #224

Open
SamuelMiller opened this issue May 9, 2022 · 2 comments

Comments

@SamuelMiller
Copy link

SamuelMiller commented May 9, 2022

function revBreak() {
    return src("dist/**/*")
        .pipe(revall.revision({ hashLength: 4 }))
        .pipe(dest("cdn"))
        .pipe(revall.manifestFile())
        .pipe(dest("cdn"))
        .pipe(revall.versionFile())
        .pipe(dest("cdn"));
};

Produces only,

{
  "assets/js/compiled.min.js": "assets/js/compiled.min.29f7.js",
  "assets/css/compiled.min.css": "assets/css/compiled.min.2559.css"
}

Ignoring all the other files that have been hashed (html, images, etc). I'm using "gulp-rev-all": "^3.0.0".

@SamuelMiller
Copy link
Author

Re-reading the documentation further, I see that by default the manifest file only outputs .css and .js. Using my first example above how would I change it so that the manifest file lists all the changes? Also, I am curious why listing all the changes is not the default--typically too many in larger sites? Many thanks for the great plugin.

@SamuelMiller SamuelMiller changed the title Bug: manifestfile only contains/outputs js and css changes? Bug: manifestfile only contains/outputs js and css changes? (edit: misread documentation) May 9, 2022
@SamuelMiller
Copy link
Author

I missed an earlier post discussing a similar issue: #165
It would be great if one could enable "all" to see all the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant