Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp rev all not including non css/js files #163

Closed
ccorda opened this issue Jan 13, 2023 · 0 comments
Closed

gulp rev all not including non css/js files #163

ccorda opened this issue Jan 13, 2023 · 0 comments
Assignees

Comments

@ccorda
Copy link
Contributor

ccorda commented Jan 13, 2023

Don't believe this was always the case, but noticed only css and js files are appearing in the manifest:
smysnk/gulp-rev-all#224

Was trying to rev some fonts, and they weren't working.

Two things:

  1. We should fix with this code:
let extensions = [
    '.html',
    '.css',
    '.js',
    '.png',
    '.jpg',
    '.jpeg',
    '.gif',
    '.svg',
    '.woff',
    '.woff2',
    '.ttf',
    '.eot',
    '.otf',
  ];
  
  $.revAll.revision({ dontSearchFile: ['.js'], includeFilesInManifest: extensions }),
  1. If a file isn't found in the manfiest, we should still output the original path.
@ccorda ccorda self-assigned this Jan 13, 2023
ccorda added a commit that referenced this issue Jan 13, 2023
@ccorda ccorda closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant