Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not updating path in file. #138

Open
adamcarr opened this issue Mar 4, 2016 · 5 comments
Open

Not updating path in file. #138

adamcarr opened this issue Mar 4, 2016 · 5 comments

Comments

@adamcarr
Copy link

adamcarr commented Mar 4, 2016

Previously, if I had a relative path string in a file that is not a require or define, like var test = './folder/path'; it would update this. After your 3/3 release, this is no longer updates.

@adamcarr
Copy link
Author

adamcarr commented Mar 4, 2016

Now, even reverting back to 0.8.22, I still see this locally. Perhaps a dependency changed that would cause this?

@adamcarr
Copy link
Author

adamcarr commented Mar 4, 2016

Commit e7d945a breaks a relative file path regex for subfolder files. Given a relative path ./routes/dashboard/dashboard, the regex created is /('|")(\/routes\/dashboard\/dashboard)()('|"|$)/g and /([^a-zA-Z0-9\.\-\_\/])(\/routes\/dashboard\/dashboard)(\.js)([^a-zA-Z0-9\.\-\_\/]|$)/g Which break. Reverting that commit fixes the issue.

@CesarD
Copy link

CesarD commented Sep 30, 2016

@smysnk
Copy link
Owner

smysnk commented Sep 30, 2016

@CesarD You are windows? What version of gulp-rev-all are you using? I have released a new version recently that includes a windows PR fix.

@CesarD
Copy link

CesarD commented Oct 14, 2016

Yes, I'm on windows. I was using the most recent version to that date. Due to project delivery times I had to go back to the combo gulp-rev & gulp-rev-replace and it worked with no issues.
I could try again tomorrow with the latest version of gulp-rev-all and see if it got fixed or not.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants