Params rework #84
Merged
Params rework #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very good upgrade, thanks @smutch! |
qyx268
approved these changes
Feb 1, 2024
EMventura
reviewed
Feb 1, 2024
qyx268
reviewed
Feb 1, 2024
qyx268
previously approved these changes
Feb 1, 2024
|
Crap! I didn't see all of your comments until after I hit merge! Sorry @qyx268 . I'll revert! |
|
I was going to say no need to revert. but i saw u did it already. the comments are all minor. just add a header in maybe input.par to instruct how this works. i know you will have it in HOWTO, but it might be worth having it there too. |
|
I will directly push to develop to address the above comments. Sorry again for missing these! |
|
np! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional extra layer of parameter files to try and reduce duplication. Parameters are read from the params file given on the command line, a defaults file (applicable to all simulations), and finally a simulation dependent parameters file (if requested). The priority is
where the lowest number wins. i.e if you set a parameter in the command line specified file and the defaults params file then the value from the former is what is used.
Some of the simulations files still need to be updated but wanted to put this out there for comment first.