#84 replace cabal with package yaml #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anka-213
reviewed
Aug 23, 2021
Comment on lines
+144
to
+145
| - tests | ||
| - src |
There was a problem hiding this comment.
I'm not sure how hpack will handle this. I would guess that it will be confused and not be able to decide which files in src belongs to which package.
There was a problem hiding this comment.
So do we ignore this PR or is there a way to fix it in package.yaml?
There was a problem hiding this comment.
I think it might already be fixed in the newer version of baby-l4.cabal
There was a problem hiding this comment.
the package.yaml file as it is now seems to generate an essentially identical baby-l4.cabal as the currently existing one; stack build and stack test run.
anka-213
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84 Replace the cabal file with package.yaml