Change error & hover IDE msgs to 1-based index

[alfredats]

Fixes #72.

Co-authored-by: akjw [email protected]

[alfredats]

We just realized that we have not tackled the other aspect of the issue, which was to use the following format:

path/to/file.l4:line:col

Will continue work for now

[anka-213]

The filename:line:column syntax depends on #96, so we remove that from this issue.

[anka-213]

I believe we also need to update the lexer/parser to make sure it uses 1-indexed line/column numbers. This was the case in an older version of baby-l4. I think that change would consist of simplifying the aposToPos function, so it no longer subtracts 1.

https://github.com/smucclaw/baby-l4/pull/31/files#diff-0c2bef627a0c8a5d583e6bb63f4887de2eea97aae8e259c79ed8ef0d74ff41eeR540-R541

But it would be the same style we would use for converting to 0-indexed for lsp.

[akjw]

With the amendments below, the tests are now passing:

• change aposToPos so that SRng is 1-indexed (Lexer.x)
• convert 1-indexed SRng to 0-indexed Range (L4LSP.hs)
• change printPos in Error.hs to reflect 1-indexed SRng (Error.hs)
• make tests use 0-indexed positions, since we're using the lsp datatypes, Range & Position (Test.hs)

[anka-213]

It's a tradeoff if we want to use 1-index or not in the tests. We could always have mkRange convert from 1-index to 0-index, but the downside with that is that the test failures will still show the errors 0-indexed. The upside is that it's more intuitive.

On the other hand, we could modify the test-helpers so they do use 1-index internally and only convert between the two different types at the very edges (i.e. in a wrapper around the calls to external lsp library functions like getHover).

[alfredats]

So we pondered for a bit, and went with the first option. We implement 2 helper functions (mkRange', mkPosition) that would take 1-indexed values and convert them to 0-indexed values.

Hopefully this would help decrease cognitive load when writing the tests, and also improve readability.

[anka-213]

Sorry for taking so long. Looks good to me. Thanks!