Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references from class method arguments #410

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

hemberger
Copy link
Member

Arguments should only be passed by reference into a function if
the function intends to modify the original variable. It should
not be used to try to improve performance (it won't: see #317).

Here we remove improper references from class method arguments,
along with a few other internal references that I missed earlier.

Arguments should only be passed by reference into a function if
the function intends to modify the original variable. It should
not be used to try to improve performance (it won't: see smrealms#317).

Here we remove improper references from class method arguments,
along with a few other internal references that I missed earlier.
@hemberger hemberger merged commit 29022b8 into smrealms:master Apr 2, 2018
@hemberger hemberger deleted the references branch April 2, 2018 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant