fix: fix namespaced attributes

smooth-code · Sep 1, 2017 · 6972f9d · 6972f9d
1 parent 1f3ca0c
commit 6972f9d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/h2x-plugin-jsx/src/index.test.js b/packages/h2x-plugin-jsx/src/index.test.js
@@ -21,7 +21,7 @@ describe('transformJsx', () => {
 
     expect(transform(code, { plugins: [transformJsx] }).trim())
       .toBe(`{/*?xml version="1.0" encoding="UTF-8"?*/}
-<svg width="88px" height="88px" viewBox="0 0 88 88" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+<svg width="88px" height="88px" viewBox="0 0 88 88" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlnsXlink="http://www.w3.org/1999/xlink">
   {/*Generator: Sketch 46.2 (44496) - http://www.bohemiancoding.com/sketch*/}
   <title>
     Dismiss

diff --git a/packages/h2x-plugin-jsx/src/visitor.js b/packages/h2x-plugin-jsx/src/visitor.js
@@ -34,14 +34,13 @@ function hyphenToCamelCase(string) {
 function getAttributeName(attribute, node) {
   if (
     !attribute.name.startsWith('aria-') &&
-    !attribute.name.startsWith('data-') &&
-    !attribute.name.includes(':')
+    !attribute.name.startsWith('data-')
   ) {
     return (
       (ELEMENT_ATTRIBUTE_MAPPING[node.name] &&
         ELEMENT_ATTRIBUTE_MAPPING[node.name][attribute.name]) ||
       ATTRIBUTE_MAPPING[attribute.name] ||
-      hyphenToCamelCase(attribute.name)
+      hyphenToCamelCase(attribute.name.replace(':', '-'))
     )
   }