Improve Stellar handling

[Zrp200]

Currently, Tera Stellar is shown in too many cases. When it's active, it is always shown, but this is misleading:

• When using a move other than tera blast, it only applies on the first time, otherwise it's identical to not being there at all
• It does nothing defensively, outside of giving a weakness to Stellar type attacks

Even in the case of Tera Blast, the first use has a different stab modifier, but both cases just display 'Tera Stellar' and 100 BP, which is incorrect --- the same description should ideally always yield the same numbers.

[Zrp200]

The only hitch is that you still can't specify timesUsed in the calculator for Tera Blast Stellar.

damage-calc/src/js/shared_controls.js

Line 509 in ecc38a8

var dropsStats =

This doesn't apply in this case, since dropsStats is only set after the calculation starts. A workaround solution is possible, but

damage-calc/calc/src/move.ts

Line 134 in ecc38a8

this.timesUsed = (this.dropsStats && options.timesUsed) || 1;

prevents actual passing of the parameter to begin with, haha. Still looking into this, however.

[thejetou]

The only hitch is that you still can't specify timesUsed in the calculator for Tera Blast Stellar.

damage-calc/src/js/shared_controls.js

Line 509 in ecc38a8

var dropsStats =

This doesn't apply in this case, since dropsStats is only set after the calculation starts. A workaround solution is possible, but

damage-calc/calc/src/move.ts

Line 134 in ecc38a8

this.timesUsed = (this.dropsStats && options.timesUsed) || 1;

prevents actual passing of the parameter to begin with, haha. Still looking into this, however.

Hm, I think a good solution would be to set an overrides of self.boosts to Move if the move is Tera Blast Stellar in shared_controls.js.

[Zrp200]

Whoops. My ide was complaining about var declarations, I told it to shut up, and it put that there. I thought I avoided committing that, but there it is. I'll remove it when I get back to my computer.

…

On Sat, Mar 16, 2024, 12:14 PM Waleed Hassan ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/js/shared_controls.js <#605 (comment)>: > @@ -1,3 +1,5 @@ +// noinspection ES6ConvertVarToLetConst ? — Reply to this email directly, view it on GitHub <#605 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWABOUIS6ALK3SUHQ3M6YLYYSKX7AVCNFSM6AAAAABEYZYAQ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBRGI4TMOBWGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Zrp200]

The only hitch is that you still can't specify timesUsed in the calculator for Tera Blast Stellar.

damage-calc/src/js/shared_controls.js

Line 509 in ecc38a8

var dropsStats =

This doesn't apply in this case, since dropsStats is only set after the calculation starts. A workaround solution is possible, but

damage-calc/calc/src/move.ts

Line 134 in ecc38a8

this.timesUsed = (this.dropsStats && options.timesUsed) || 1;

prevents actual passing of the parameter to begin with, haha. Still looking into this, however.

Hm, I think a good solution would be to set an overrides of self.boosts to Move if the move is Tera Blast Stellar in shared_controls.js.

Is this not what the current implementation does?

damage-calc/src/js/shared_controls.js

Line 1068 in a5551ab

if (moveName === 'Tera Blast') {

[thejetou]

Suggested change

	var statDrops = moveInfo.find('.stat-drops');
	var dropsStats = statDrops.is(':visible');
	if (isStellar !== dropsStats) {
	// update stat drop dropdown here
	if (isStellar) statDrops.show(); else statDrops.hide();
	var statDrops = moveInfo.find('.stat-drops');
	var dropsStats = statDrops.is(':visible');
	if (isStellar !== dropsStats) {
	isStellar ? statDrops.show() : statDrops.hide();

[Zrp200]

What does this do? This results in an error, since you cut out statDrops entirely, plus I don't understand why you converted an if statement to a tertiary operator.

[thejetou]

Oh, I didn't see that statDrops is used in dropsStats too. I'll edit that out.

If the if statement is simple enough it's just more concise to write is a ternary expression which is why I converted it.

[Zrp200]

I reverted the implementation, since doing this violates the linter, and it also messed with some of the formatting.

[thejetou]

Thank you!