-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neutral Mass Spectrum #806
Open
nbollis
wants to merge
11
commits into
smith-chem-wisc:master
Choose a base branch
from
nbollis:NeutralMzSpectrum
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+417
−98
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc1b6a9 - Browse repository at this point
Copy the full SHA bc1b6a9View commit details -
Refactor visibility and clean up deconvolution code
Changed `ClassicDeconvolutionAlgorithm`, `DeconvolutionAlgorithm`, and `ExampleNewDeconvolutionAlgorithmTemplate` classes and their members from `public` to `internal` to restrict visibility within the assembly. Added summary comment to `DeconvolutionAlgorithm` class. Refactored `Deconvoluter` class to remove unnecessary `using` directives and simplify the `Deconvolute` method by removing switch-case logic. Updated `IsotopicEnvelope` class by removing `MassIndex` and `StDev` properties, and modified constructor and `ScoreIsotopeEnvelope` method accordingly. Updated `MzSpectrum` class to use `StandardDeviation` extension method from `Easy.Common.Extensions`. Removed various unnecessary `using` directives from multiple files.
Nic Bollis committedOct 11, 2024 Configuration menu - View commit details
-
Copy full SHA for a8bba37 - Browse repository at this point
Copy the full SHA a8bba37View commit details -
- Added `InternalsVisibleTo` entries for "Development" and "Test" in `MassSpectrometry.csproj`. - Changed `MostAbundantObservedIsotopicMass` to `internal` in `IsotopicEnvelope.cs`. - Added a new constructor to `IsotopicEnvelope` with monoisotopic mass, intensity, and charge. - Added XML documentation and changed `GeneratePeak` to `protected virtual` in `MzSpectrum.cs`. - Removed unused `using` directives in `MzSpectrum.cs` and `NeutralMzSpectrum.cs`. - Modified `NeutralMzSpectrum` constructor to validate array lengths. - Added `Charges` property to `NeutralMzSpectrum` and initialized it in the constructor. - Overrode `GeneratePeak` in `NeutralMzSpectrum` to convert to a charged spectrum using `Charges`.
Nic Bollis committedOct 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 455f3c0 - Browse repository at this point
Copy the full SHA 455f3c0View commit details -
Refactor Deconvoluter and rename NeutralMzSpectrum
Added necessary using directives in Deconvoluter.cs. Modified Deconvoluter class for short-circuit deconvolution. Removed redundant lines in Deconvoluter.cs. Renamed NeutralMzSpectrum to NeutralMassSpectrum. Updated constructor and references accordingly.
Nic Bollis committedOct 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 0dd9e52 - Browse repository at this point
Copy the full SHA 0dd9e52View commit details -
Nic Bollis committed
Oct 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 09cefc7 - Browse repository at this point
Copy the full SHA 09cefc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72d8202 - Browse repository at this point
Copy the full SHA 72d8202View commit details
Commits on Oct 12, 2024
-
Refactor Deconvoluter and add new tests
Refactored Deconvoluter.cs to use a foreach loop for yielding IsotopicEnvelopes. Reformatted multiple test methods in TestDeconvolution.cs for better readability. Added new test methods to validate Deconvolute with NeutralMassSpectrum, ensuring correct processing of spectra with various charge states and ranges.
Configuration menu - View commit details
-
Copy full SHA for 4277814 - Browse repository at this point
Copy the full SHA 4277814View commit details -
Make FirstX and LastX properties virtual; update tests
- Changed FirstX and LastX properties in MzSpectrum to virtual. - Included MzLibUtil namespace in NeutralMassSpectrum class. - Updated NeutralMassSpectrum constructor to set FirstX and LastX. - Overrode FirstX and LastX in NeutralMassSpectrum class. - Added test NeutralMassSpectrum_MzRange to validate m/z range.
Configuration menu - View commit details
-
Copy full SHA for 6c124c5 - Browse repository at this point
Copy the full SHA 6c124c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f049ee4 - Browse repository at this point
Copy the full SHA f049ee4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fb3da3 - Browse repository at this point
Copy the full SHA 9fb3da3View commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8a6fc81 - Browse repository at this point
Copy the full SHA 8a6fc81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.