enh: full-stack preview app enhancements #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sst v3 is now a stable release. this removes the need for the go binary install step. npm wins, yet again
ayinloya
reviewed
Aug 28, 2024
| import { Resource } from 'sst'; | ||
| import products from '~/data/products.json'; | ||
|
|
||
| declare global { | ||
| interface Window { | ||
| SmileIdentity: Function; | ||
| SmileIdentity: function; |
There was a problem hiding this comment.
Suggested change
| SmileIdentity: function; | |
| SmileIdentity: Function; |
ayinloya
added a commit
that referenced
this pull request
Oct 22, 2024
* add previews * Add preview app * link files * Fix lint * Downgrade sst due to this issue https://github.com/sst/ion/issues/774 * Update readme * Add destroy workflow when pr is closed * Fix destroy deployed preview app workflow name * Add script to retrieve the app url * Set the right branch name for deployment Share preview app url as comment on PR * Deploy preview regardless of outcome of other steps * Sanitize branch name * Fix sst url after deploy * fix share preview url * use $GITHUB_HEAD_REF to get branch name when sharing preivew * Support deployment when pr is reopened * use sanitized branch name for preview url sharing * Remove pr reopened from workflow * resolve package-lock * enh: full-stack preview app enhancements (#317) * refactor: change `SS_STAGE` to `SST_STAGE` * deps: use latest stable release of sst sst v3 is now a stable release. this removes the need for the go binary install step. npm wins, yet again * fix: fix lint, prettier issues * refactor: remove redundant `default_app` directory --------- Co-authored-by: Barnabas A Nsoh <[email protected]> * Fix lint * add npm to run deploy preview * add sst script --------- Co-authored-by: tams sokari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
default_appdirectoryit is created to fix the issue @ayinloya flagged re: using this in CI.
so far, from the base branch, it is not clear what the issue is.
my current assumption is that the issue is adding the full-stack preview URL in a github comment. @ayinloya is that the case?