Fix agent mode showing when flag is present (#326)

* Fix agent mode showing when flag is present * fix agent mode check * add test * revert unrelated changes * revert unrelated changes * fix lint * fix test * chore: format code --------- Co-authored-by: Khalifa Lame <[email protected]>
smileidentity · Sep 5, 2024 · acabd69 · acabd69
1 parent 8348ba4
commit acabd69
Show file tree

Hide file tree

Showing 11 changed files with 81 additions and 23 deletions.
diff --git a/example/package.json b/example/package.json
@@ -1,7 +1,7 @@
 {
   "name": "example",
   "private": true,
-  "version": "1.4.1",
+  "version": "1.4.2",
   "type": "module",
   "main": "server.js",
   "scripts": {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@smileid/web",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "A collection of SmileID browser clients and components",
   "main": "index.js",
   "private": true,

diff --git a/packages/embed/package.json b/packages/embed/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@smileid/embed",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "Self Hosted Integration for Smile Identity on the Web",
   "private": true,
   "main": "inline.js",

diff --git a/packages/smart-camera-web/package.json b/packages/smart-camera-web/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@smile_identity/smart-camera-web",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "WebComponent for smartly capturing images on the web, for use with SmileIdentity",
   "main": "smart-camera-web.js",
   "scripts": {

diff --git a/packages/web-components/components/selfie/src/SelfieCaptureScreens.js b/packages/web-components/components/selfie/src/SelfieCaptureScreens.js
@@ -180,9 +180,7 @@ class SelfieCaptureScreens extends HTMLElement {
   }
 
   get allowAgentMode() {
-    return this.hasAttribute('allow-agent-mode')
-      ? "allow-agent-mode='true'"
-      : '';
+    return this.inAgentMode ? "allow-agent-mode='true'" : '';
   }
 
   get allowAgentModeTests() {

diff --git a/packages/web-components/components/signature-pad/package.json b/packages/web-components/components/signature-pad/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@smileid/signature-pad",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "private": "true",
   "exports": {
     ".": "./index.js"

diff --git a/packages/web-components/components/smart-camera-web/src/SmartCameraWeb.js b/packages/web-components/components/smart-camera-web/src/SmartCameraWeb.js
@@ -61,19 +61,21 @@ class SmartCameraWeb extends HTMLElement {
 
   static get observedAttributes() {
     return [
+      'allow-agent-mode',
       'disable-image-tests',
       'document-capture-modes',
       'document-type',
+      'hide-attribution',
       'hide-back-of-id',
       'hide-back-to-host',
       'show-navigation',
       'theme-color',
-      'hide-attribution',
     ];
   }
 
   attributeChangedCallback(name) {
     switch (name) {
+      case 'allow-agent-mode':
       case 'disable-image-tests':
       case 'document-capture-modes':
       case 'document-type':

diff --git a/packages/web-components/cypress/e2e/smart-camera-web-agent-mode.cy.js b/packages/web-components/cypress/e2e/smart-camera-web-agent-mode.cy.js
@@ -2,12 +2,19 @@ context('SmartCameraWeb', () => {
   beforeEach(() => {
     cy.visit('/smart-camera-web-agent-mode');
   });
+
   it('should switch from the selfie mode to agent mode"', () => {
     cy.log('Enable agent mode for tests');
     cy.get('smart-camera-web')
-      .shadow()
-      .find('selfie-capture')
-      .invoke('attr', 'show-agent-mode-for-tests', 'true');
+      .invoke('attr', 'allow-agent-mode', 'true')
+      .should('have.attr', 'allow-agent-mode', 'true');
+
+    cy.get('smart-camera-web').invoke(
+      'attr',
+      'show-agent-mode-for-tests',
+      'true',
+    );
+    cy.get('smart-camera-web').invoke('attr', 'disable-image-tests', '');
 
     cy.clock();
     cy.get('smart-camera-web')
@@ -80,4 +87,58 @@ context('SmartCameraWeb', () => {
       .find('selfie-capture-review')
       .should('be.visible');
   });
+
+  it('should not show the agent mode switch button"', () => {
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture')
+      .invoke('attr', 'show-agent-mode-for-tests', 'false');
+    cy.get('smart-camera-web').invoke('attr', 'disable-image-tests', '');
+
+    cy.clock();
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture-instructions')
+      .shadow()
+      .find('#allow')
+      .click();
+
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture')
+      .should('be.visible');
+
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture')
+      .shadow()
+      .find('#switch-camera')
+      .should('not.exist');
+
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture')
+      .shadow()
+      .should('contain.text', 'Take a Selfie');
+
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture')
+      .shadow()
+      .find('#start-image-capture')
+      .click();
+
+    cy.tick(8000);
+
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture')
+      .shadow()
+      .should('not.be.visible');
+
+    cy.get('smart-camera-web')
+      .shadow()
+      .find('selfie-capture-review')
+      .should('be.visible');
+  });
 });
diff --git a/packages/web-components/cypress/pages/smart-camera-web-agent-mode.html b/packages/web-components/cypress/pages/smart-camera-web-agent-mode.html
@@ -25,10 +25,7 @@
   </head>
 
   <body>
-    <smart-camera-web
-      disable-image-tests
-      allow-agent-mode="true"
-    ></smart-camera-web>
+    <smart-camera-web></smart-camera-web>
 
     <script src="./js/components/smart-camera-web/src/SmartCameraWeb.js"></script>
     <script>

diff --git a/packages/web-components/package.json b/packages/web-components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@smileid/web-components",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "private": "true",
   "exports": {
     ".": "./index.js",