New UI Instructions Screen #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNdhlovu
requested changes
Oct 4, 2024
| verify(atLeast = 1, timeout = 1000) { viewModel.analyzeImage(any(), camSelector) } | ||
| } | ||
| // todo broke test | ||
| // @OptIn(ExperimentalTestApi::class) |
There was a problem hiding this comment.
@jumaallan this will be in a seperate PR?
| @@ -22,7 +23,7 @@ fun SmileIDTheme(content: @Composable () -> Unit) { | |||
|
|
|||
| MaterialTheme( | |||
| colorScheme = SmileID.colorScheme, | |||
| typography = SmileID.typography, | |||
| typography = SmileID.typographyv2, | |||
There was a problem hiding this comment.
Will we be removing typography for typographyv2? We changed it here but it's still extensively used throughout
There was a problem hiding this comment.
I am doing this on the new screens to experiment new theming - and, this feature does not get to main branch
JNdhlovu
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/xxx
Summary
A few sentences/bullet points about the changes
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.