Fix Upload Retry Bug #436
Merged
Fix Upload Retry Bug #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNdhlovu
requested changes
Sep 2, 2024
| throwable is HttpException -> { | ||
| val smileIDException = throwable.toSmileIDException() | ||
| if (smileIDException.details.code == "2215") { | ||
| SmileID.api.prepUpload(prepUploadRequest.copy(retry = true)) |
There was a problem hiding this comment.
@jumaallan we're starting to have duplication of code, is it possible to extract what we have in common between products and reuse that, this is a good example of docv and biometric kyc doing the same thing
There was a problem hiding this comment.
We cannot abstract this code per se since we need this flow inside submit job scope - we also modify the previous request so we need to be in the same lambda to avoid passing request and response body back and forth
|
Do we need to worry about https://docs.usesmileid.com/further-reading/result-codes/error-codes 2314 ? |
No, we are taking care of a different error code here |
JNdhlovu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/13456/fairmoney-issue-investigate-and-fix
Summary
A few sentences/bullet points about the changes
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.