Fail active liveness after timeout #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaallan
approved these changes
Jun 18, 2024
vanshg
added a commit
that referenced
this pull request
Jun 18, 2024
vanshg
added a commit
that referenced
this pull request
Jul 11, 2024
* Randomized face direction * Add halfway captures * add stability timer * Add docs, cleanup * Move to util; add constants * Bump versions * Add useStrictMode (#362) * Add useStrictMode * Fix test * Bump versions * Active liveness UI (#363) * Add useStrictMode * wip * New UI prototype, less finicky * add docs * More UI updates * Fix test * Add active liveness forced failure and update design (#364) * Add useStrictMode * wip * New UI prototype, less finicky * add docs * More UI updates * Add metadata * Fix test * Add forced failure * update timeout * remove unused value * add breadcrumbs * increase num liveness images and add doc * prevent rotation * Add CameraFrameCornerBorder * restructure + loading/success/error * cleanup * Update library version * Add smile directive * Use Lottie for directive animations (#366) * Add Lottie face animation * Fix need light animation * Add Enrollment v2 (#367) * Add Enrollment v2 * Fix test * Impose upper bound on active liveness head angle (#368) * Impose upper bound on active liveness head angle * Update condition * Add missing compatibility properties, agent mode, and attribution * Move to constants * Bump lottie * Fix bad version * Metadata * Allow parameter tuning * Active liveness parameter tuning. Update face quality model input crop * Add header metadata back for now * Fix contour out of bounds https://smile-identity.sentry.io/issues/5453193521 * Make feedback more responsive during active liveness * ignore certain faces. debug output * Update CHANGELOG * Fix viewfinder rect * Lint * Merge * Reset capture progress on orientation change (#382) * Reset capture progress on orientation change * Lint * Bump versions * UI update and task confirmation (#385) * Parameter updates, clipboard copy, larger UI * Fail active liveness after timeout (#390) * Use oval cutout * Update parameters * Remove parameter tuning and debug output * Add useStrictMode to top level composable * Use Strict Mode naming on main screen * Update versions * Revert up angle
vanshg
added a commit
that referenced
this pull request
Jul 16, 2024
* Randomized face direction * Add halfway captures * add stability timer * Add docs, cleanup * Move to util; add constants * Bump versions * Add useStrictMode (#362) * Add useStrictMode * Fix test * Bump versions * Active liveness UI (#363) * Add useStrictMode * wip * New UI prototype, less finicky * add docs * More UI updates * Fix test * Add active liveness forced failure and update design (#364) * Add useStrictMode * wip * New UI prototype, less finicky * add docs * More UI updates * Add metadata * Fix test * Add forced failure * update timeout * remove unused value * add breadcrumbs * increase num liveness images and add doc * prevent rotation * Add CameraFrameCornerBorder * restructure + loading/success/error * cleanup * Update library version * Add smile directive * Use Lottie for directive animations (#366) * Add Lottie face animation * Fix need light animation * Add Enrollment v2 (#367) * Add Enrollment v2 * Fix test * Impose upper bound on active liveness head angle (#368) * Impose upper bound on active liveness head angle * Update condition * Add missing compatibility properties, agent mode, and attribution * Move to constants * Bump lottie * Fix bad version * Metadata * Allow parameter tuning * Active liveness parameter tuning. Update face quality model input crop * Add header metadata back for now * Fix contour out of bounds https://smile-identity.sentry.io/issues/5453193521 * Make feedback more responsive during active liveness * ignore certain faces. debug output * Update CHANGELOG * Fix viewfinder rect * Lint * Merge * Reset capture progress on orientation change (#382) * Reset capture progress on orientation change * Lint * Bump versions * UI update and task confirmation (#385) * Parameter updates, clipboard copy, larger UI * Fail active liveness after timeout (#390) * Use oval cutout * Update parameters * Remove parameter tuning and debug output * Add useStrictMode to top level composable * Use Strict Mode naming on main screen * Update versions * MetadataAdapter comment * Add metadata to prepUpload * Track document image origin (#398) * Track document image origin * Update test * Update test * Update test * Add fingerprint (#400) * Track document image origin * Update test * Add fingerprint * Use default empty string instead of lateinit var * Update test * Track metrics using CompositionLocal (#402) * Track metrics using CompositionLocal * Clear DocumentCapture metadata on retry * Clarify some metadata * Update naming and format * Update names * Send metadata on DocV * Fix enum value * Update CHANGELOG * Merge * Fix colors * Remove fingerprint JS * Update settings.gradle.kts * Prepare for 10.2.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/12973
Summary
Once the active liveness timer expires, the job is submitted with
failure_reason.mobile_active_liveness_timed_outset totrue