feat(editor): add extract module feature #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanbowensg
force-pushed
the
feat/extract-module
branch
from
2aa5095 to
19b7c03
Compare
tanbowensg
commented
Jan 13, 2023
|
|
||
| options.scopeObject = { | ||
| ...options.scopeObject, | ||
| $slot: redirector, | ||
| $slot: options.slotKey ? store[options.slotKey] : undefined, |
There was a problem hiding this comment.
The original way pass a Proxy to $slot. But $slot doesn't work in module if using Proxy. So I pass store[options.slotKey] as $slot to fix this bug.
xzdry
approved these changes
Jan 18, 2023
tanbowensg
force-pushed
the
feat/extract-module
branch
from
19b7c03 to
10bc795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This feature can help user to extract sunmao components into module to refactor old code.
To do so, user need to choose a component as the root of module. This component and its children will be moved into new module. Sunmao will auto analyse the relationship of dependency between in-module components and out-module components. According to the relationship, sunmao will auto generate new module config and modify the properties of related components. Sunmao did most job of extracting module, user only need click to use.
related issue: #581
default.mov