SKS-3173: Use cape-controller-manager ServiceAccount & fix elfMachineTemplate permissions #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket
[SKS-3173] [CAPE] cape-controller 和 cape-ip-controller 混用了 RBAC 权限 - Jira
cape-controller 和 cape-ip-controller 都是用 default sa，导致它们的 RBAC 混用了。
changed
test
生成的 manifests:
在未添加 elfmachinetemplate 时修改 elfmachine，webhook 会报错无权限：
添加 elfmachinetemplate 后再修改，正确报错：