-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKS-1825: Support setting IPPools for network devices #165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.4 #165 +/- ##
============================================
Coverage 59.72% 59.72%
============================================
Files 20 20
Lines 3615 3615
============================================
Hits 2159 2159
Misses 1308 1308
Partials 148 148 ☔ View full report in Codecov by Sentry. |
metadata.yaml
Outdated
@@ -6,6 +6,9 @@ | |||
apiVersion: clusterctl.cluster.x-k8s.io/v1alpha3 | |||
kind: Metadata | |||
releaseSeries: | |||
- major: 1 | |||
minor: 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPE先不用发1.4.0,继续使用1.3.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如何区分 1.3 和 1.4 的代码。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SKS 1.2.0 使用 CAPE 1.3.0
SKS 1.3.0 继续使用 CAPE 1.3.x 暂时不需要用1.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用 release-1.3.x 分支?
Issue
支持为网卡配置 IPPool
Change
CAPE IPAM 技术文档
相关的PR:smartxworks/cluster-api-provider-elf-static-ip#34
Test
ElfMachine 配置 IPPool,分配到了 IP。
IPPool 分配了 IP。