-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Partial Results Logging and Request Options #222
Merged
positiveVibes4all
merged 5 commits into
main
from
feature/enable_partial_results_config_and_logging
Jun 14, 2024
Merged
Add Partial Results Logging and Request Options #222
positiveVibes4all
merged 5 commits into
main
from
feature/enable_partial_results_config_and_logging
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates logic for child searches to allow for elastic request options to come from the code consuming the client.
🦋 Changeset detectedLatest commit: 5015cf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage after merging feature/enable_partial_results_config_and_logging into main will be
Coverage Report
|
stellarhoof
approved these changes
Jun 14, 2024
positiveVibes4all
deleted the
feature/enable_partial_results_config_and_logging
branch
June 14, 2024 21:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the ability to consume passed in parameters to control partial results and the timeout associated to those results. This PR also enables logging if a custom logger is provided.