-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide individual filters scrollbar #206
Conversation
Our contexture-react components have outdated layouts with negative margins and other brittle things which causes filters to overflow horizontally when scroll bars are shown. This PR hides them to prevent this from happening.
🦋 Changeset detectedLatest commit: f3e07ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage after merging feature/hide-filter-scrollbar into main will be
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! I just need to verify the changes locally 🙏🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked and tested changes, they look good and behave as we discussed.
Summary
Our contexture-react components have outdated layouts with negative
margins and other brittle things which causes filters to overflow
horizontally when scroll bars are shown. This PR hides them to prevent
this from happening.