Issue 59: Support crontab ranges 'x-y' and 'x/y' #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. add support for interval specification using "/x" . add support for range specification using "x-y" . refactor a little bit to have one block which handles a single item, which is used recursively when using ",", "/x" or "x-y" # implements suggestion of issue smarthomeNG#59 - log exception message when error occurs while analyzing the crontab entry
done in the top part of the function
This was referenced May 14, 2016
|
Hey, ich würde das gerne mergen, oder hat jemand etwas dagegen? |
|
in den DEV oder? für mich ok, kann mir auch einen use case zum testen überlegen... |
|
ja develop |
cstrassburg
pushed a commit
that referenced
this pull request
Dec 10, 2016
* - change _range() function in sheduler: . add support for interval specification using "/x" . add support for range specification using "x-y" . refactor a little bit to have one block which handles a single item, which is used recursively when using ",", "/x" or "x-y" # implements suggestion of issue #59 - log exception message when error occurs while analyzing the crontab entry * - remove list handling of basic items in _range(), which is already done in the top part of the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(copied from mknx/smarthome#61)
I started to refactor the
scheduler._range()function a little bit and implemented support forx/yandx-yas requested in issue #59. The function was changed to resolve thecrontabelements from complex to simple elements.The following complex elements are supported now in
crontabsetting:1,2,3,4,8-10*/20-8Since the resolving is implemented in a recusive way, it's also possible to combine all of them. E.g. you can use
1,2,3,4,8-10or1-4,5-23/2or something similar. The first one will include the hours between 1-4 and 8-10, the second one will include the hours between 1-4 and each even hour between 5 and 23.