Menu Manager Refactor and Updating Implementation #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added stubs for operations * Added configuration update operation * Added open menu operation
joeljfischer
added
proposal
* Configuration update early returns need to finish the operation
* Move enum to update algorithm file in order to make it more easily available to operations * Fix menu manager hmi level / menu context suspension of queue * Move updating menu cells to delete / send to dynamic operation * Fix setting ids to be in menu manager and out of dynamic operation
* Refactor checking artworks to use whichever ones actually uploaded and skipping showing any that failed * Add menu replace operation cancelled errors
* In progress changes to track and pass back current menu state
# Conflicts: # Cartfile.private
# Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj
* Move transfer cell id method to menu replace utilities * Rename `updateIdsOnMenuCells` to `addIdsToMenuCells` on SDLMenuReplaceUtilities * Update menu replace operation: * Re-add transferring Ids on keeps * Update names of delete / add menu cell methods * Add menu cell method now doesn't send submenus
* Many method name clarification updates * Hopefully fix mis-using global updatedMenu when submenus are in view * Re-enable sending submenus for add cells that are not submenus of keeps
This was
linked to
issues
Aug 23, 2021
* Fixed menu handlers not using current menu
FrankElias77
requested changes
Sep 1, 2021
FrankElias77
approved these changes
Sep 10, 2021
FrankElias77
previously approved these changes
Sep 14, 2021
# Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj # SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-Swift.xcscheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1957, #2027, #2028
Partially Fixes #1898
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit tests added and refactored
Core Tests
Core version / branch / commit hash / module tested against: Manticore (v7.1.1), Sync v3.4
HMI name / version / branch / commit hash / module tested against: Manticore (v0.10.0), Sync v3.4
Summary
This PR refactors the main menu manager to use operation queues and fixes many bugs.
Changelog
Bug Fixes
Tasks Remaining:
n/a
CLA