-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start updating RPCs with generated initializers #1824
Draft
joeljfischer
wants to merge
16
commits into
develop
Choose a base branch
from
bugfix/issue-1821-use-generated-initializers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Start updating RPCs with generated initializers #1824
joeljfischer
wants to merge
16
commits into
develop
from
bugfix/issue-1821-use-generated-initializers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
added
best practice
Not a defect but something that should be improved anyway
rpc
Relating to the RPC layer
labels
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1824 +/- ##
===========================================
- Coverage 84.65% 76.84% -7.81%
===========================================
Files 418 418
Lines 20971 23093 +2122
===========================================
- Hits 17753 17746 -7
- Misses 3218 5347 +2129 |
# Conflicts: # SmartDeviceLink/public/SDLKeyboardProperties.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
best practice
Not a defect but something that should be improved anyway
rpc
Relating to the RPC layer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1821
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit tests updated for new and deprecated initializers
Core Tests
Example apps run
Core version / branch / commit hash / module tested against: Manticore (Core 6.1.1)
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.8.1)
Summary
This PR adds all generated initializers and deprecates many older initializers.
Changelog
Enhancements
Tasks Remaining:
CLA