Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start updating RPCs with generated initializers #1824

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

joeljfischer
Copy link
Contributor

Fixes #1821

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests updated for new and deprecated initializers

Core Tests

Example apps run

Core version / branch / commit hash / module tested against: Manticore (Core 6.1.1)
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.8.1)

Summary

This PR adds all generated initializers and deprecates many older initializers.

Changelog

Enhancements
  • Added RPC initializers generated by the RPC generator and deprecated old initializers.

Tasks Remaining:

  • Finish adding / deprecating all initializers
  • Fix deprecations in unit tests
  • Add new unit tests for new initializers

CLA

@joeljfischer joeljfischer added best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer labels Oct 20, 2020
@joeljfischer joeljfischer self-assigned this Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1824 (dda5341) into develop (361db38) will decrease coverage by 7.80%.
The diff coverage is 3.32%.

@@             Coverage Diff             @@
##           develop    #1824      +/-   ##
===========================================
- Coverage    84.65%   76.84%   -7.81%     
===========================================
  Files          418      418              
  Lines        20971    23093    +2122     
===========================================
- Hits         17753    17746       -7     
- Misses        3218     5347    +2129     

@joeljfischer joeljfischer marked this pull request as draft May 17, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant