Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATF Script for defect 1846 #2120

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

ATF Script for defect 1846 #2120

wants to merge 3 commits into from

Conversation

KrupenichOleg
Copy link
Contributor

@KrupenichOleg KrupenichOleg commented Oct 18, 2018

ATF Test Scripts to check #1846

This PR is [ready] for review.

Summary

New ATF scripts to check the issue.

ATF version

develop

Changelog

  • New scripts
  • Added new script in the test set for the issues in the scope of 7.1 release

CLA

--
-- WARNING: you should include "Navigation-1" group in "sdl_preloaded_pt.json" file before run
-- this test!
---------------------------------------------------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg Please update description in one of two ways:

  1. In case .... SDL does ...
  2. Steps ... Expected ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi Done in commit 20db55e. Also PTU added to preconditions.


runner.Title("Test")
runner.Step("Negative check mandatory parameter distanceToManeuver", checkShowConstantTBT, {{
appID = common.getHMIAppId(1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg appID is not a part of parameters list for ShowConstantTBT in MOBILE API. Please notice list of parameters for MOBILE API could differ from list for HMI API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg The same in lines 45 and 50

@smartdevicelink smartdevicelink deleted a comment from dboltovskyi Oct 29, 2018
@KrupenichOleg KrupenichOleg changed the title ATF Script for Defect 1846 ATF Script for defect 1846 Oct 29, 2018
-- distanceToManeuver
-- distanceToManeuverScale
-- The MOBILE_API is reflecting that these parameters are not mandatory, whereas the HMI_API
-- reflects that they are mandatory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg Please remove lines 7 through 12

}, {success = true, resultCode = "SUCCESS"}})

runner.Title("Postconditions")
runner.Step("Stop SDL", common.postconditions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg Please add new line at the end of the script

local function checkShowConstantTBT(pParams, pResultTable)
local cid = common.getMobileSession():SendRPC("ShowConstantTBT", pParams)
common.getMobileSession():ExpectResponse(cid, pResultTable)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@KrupenichOleg KrupenichOleg Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi all done in commit 1435755

@IGapchuk
Copy link
Contributor

PR is rebased on current develop(273b79d) branch.
The script is applicable to all policy flows and transport types.
Script has been moved to 6_1 folder.
The test set for the script is added.

@GetmanetsIrina
Copy link
Contributor

The script is rebased on the actual develop branch (67f11b7)

@GetmanetsIrina GetmanetsIrina removed the request for review from HSavynetska April 6, 2021 12:19
Base automatically changed from develop to master April 14, 2021 16:06
@ShobhitAd ShobhitAd changed the base branch from master to develop April 14, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants