-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATF Script for defect 1846 #2120
base: develop
Are you sure you want to change the base?
Conversation
-- | ||
-- WARNING: you should include "Navigation-1" group in "sdl_preloaded_pt.json" file before run | ||
-- this test! | ||
--------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrupenichOleg Please update description in one of two ways:
- In case .... SDL does ...
- Steps ... Expected ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dboltovskyi Done in commit 20db55e. Also PTU added to preconditions.
|
||
runner.Title("Test") | ||
runner.Step("Negative check mandatory parameter distanceToManeuver", checkShowConstantTBT, {{ | ||
appID = common.getHMIAppId(1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrupenichOleg appID
is not a part of parameters list for ShowConstantTBT
in MOBILE
API. Please notice list of parameters for MOBILE
API could differ from list for HMI
API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrupenichOleg The same in lines 45
and 50
-- distanceToManeuver | ||
-- distanceToManeuverScale | ||
-- The MOBILE_API is reflecting that these parameters are not mandatory, whereas the HMI_API | ||
-- reflects that they are mandatory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrupenichOleg Please remove lines 7 through 12
}, {success = true, resultCode = "SUCCESS"}}) | ||
|
||
runner.Title("Postconditions") | ||
runner.Step("Stop SDL", common.postconditions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrupenichOleg Please add new line at the end of the script
local function checkShowConstantTBT(pParams, pResultTable) | ||
local cid = common.getMobileSession():SendRPC("ShowConstantTBT", pParams) | ||
common.getMobileSession():ExpectResponse(cid, pResultTable) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrupenichOleg This steps are not enough for successful result. Please see full flow in https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/develop/test_scripts/Smoke/API/016_ShowConstantTBT_PositiveCase_SUCCESS.lua
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dboltovskyi all done in commit 1435755
PR is rebased on current develop(273b79d) branch. |
9fe6d21
to
1bb65f0
Compare
The script is rebased on the actual develop branch (67f11b7) |
ATF Test Scripts to check #1846
This PR is [ready] for review.
Summary
New ATF scripts to check the issue.
ATF version
develop
Changelog
7.1
releaseCLA