Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation for Preset names and Preset 0. #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelCrimando
Copy link

A current problem we're having is that there's no consistent documentation with preset 0. Should it be first in the preset list or last? This matters if you're setting custom preset names, since the app just sends an array of strings to name the presets. So if preset 0 is in the wrong spot, it throws off all the preset names. Currently Pandora considers it as preset 10 vs iHeartRadio considers it as preset 0.

This came up because we've never had a sync that can use 10 presets AND show the preset label.
sync3 only does presets 1-8 and shows labels.
sync1 does 10 presets but no labels

@MichaelCrimando
Copy link
Author

@theresalech can you give this a review plz?

@joeygrover
Copy link
Member

@MichaelCrimando the README.md is generated from the actual xml file MOBILE_API.xml . Sorry this can be a bit confusing. The XML file is the source of truth, we generate the README from it, then copy that into the developer portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants